Fix tag version check#603
Merged
Merged
Conversation
…e release Also update the job dependency graph: - have the release jobs depend on the test and version-checking jobs - have the test and version-checking jobs depend on the build job
popescu-v
force-pushed
the
fix-tag-version-check
branch
from
54b6a9d to
1540651
Compare
tramora
approved these changes
Jul 3, 2026
tramora
left a comment
tramora
left a comment
Collaborator
There was a problem hiding this comment.
Approved with a minor remark : an obsolete comment should be removed
| @@ -36,8 +38,10 @@ jobs: | |||
Collaborator
There was a problem hiding this comment.
I remember you reminded me to remove this obsolete comment somewhere else. I should have 'greped' for it in the whole project
Collaborator
Author
There was a problem hiding this comment.
Right. I'd add this removal to the commit on the "paragraph-oriented way".
popescu-v
force-pushed
the
fix-tag-version-check
branch
from
1540651 to
f4c369c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the check into a separate job, needed by the release job.
TODO Before Asking for a Review
main(ormain-v10)